Test#2
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| if command -v bbcertify; then | ||
| cert_file=$(bbcertify --no-reservation) | ||
| reservation_file="${HOME}/.config/dosaygo/bbpro/tickets/reservation.json" | ||
| if [ $? -eq 0 ] && [ -n "$cert_file" ] && [ -f "$cert_file" ]; then |
There was a problem hiding this comment.
Exit code check tests wrong command's result
The $? on this line checks the exit status of the reservation_file=... variable assignment on line 166, not the bbcertify --no-reservation command on line 165. Variable assignments typically return 0, so the condition will pass even if bbcertify fails. The exit status should be captured immediately after the command subprocess, e.g., by checking within the same compound statement or storing in a variable right after line 165.
| trap 'echo -e "\n${NC}Test Summary:"; \ | ||
| echo -e "${GREEN}Passed: $passed${NC}"; \ | ||
| echo -e "${RED}Failed: $failed${NC}"; \ | ||
| echo -e "${YELLOW}Warnings: $warnings${NC}"' EXIT |
There was a problem hiding this comment.
Second EXIT trap replaces cleanup trap
Setting a second trap ... EXIT on line 195 replaces the first trap set on line 187. This means saga_bbx_stop &>/dev/null will never be called via the trap mechanism. If the script exits unexpectedly (e.g., via exit 1 during installation failures), the BrowserBox cleanup won't run. The traps need to be combined into a single trap command or use a cleanup function that performs both actions.
Additional Locations (1)
2 participants
Note
Overview
.github/workflows/bbx-saga.yaml) that installs BrowserBox via release installers, runs end-to-end tests (run/ng-run/tor-run/cf-run), and supports containers, tmate-on-failure, and Windows checks.Key changes
/.github/scripts/test-bbx.shto exercisebbxsetup/run paths, validate login/service links, and collect logs; handles root→user handoff and port/nginx conflicts.deploy-scripts/install.sh(Unix/macOS) downloads release assets, verifies signedrelease.manifest.json, selects platform artifact, and runs--install/--full-install.windows-scripts/install.ps1downloads/validates signed binaries, installs commands viacp_commands_only.ps1, and splits dependency setup intoinstall_deps.ps1; improves update prompts and config paths.bbx.shhardens env/paths (dosaygo), redirectsinstallto browserbox.io installer, improves Cloudflare edge selection, multi-user manifest placement, and user handoff/ownership fixes; usage/help text updated.admin-tools/retrigger-public-saga.sh,AGENTS.md,INDEX.md,docs/*for saga iteration and release flow.Written by Cursor Bugbot for commit eda1816. This will update automatically on new commits. Configure here.